Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Claim issue fix #671

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Claim issue fix #671

merged 1 commit into from
Jan 16, 2023

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Jan 16, 2023

Pull Request Summary

Because of weights V2 are introduced to Shibuya and Shiden claim feature stopped working.

image

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

Release notes:

  • Fix for Claim All error

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit fd6a1e3):

https://astar-apps--pr671-fix-weight-v2-issue-i58e3tqg.web.app

(expires Mon, 23 Jan 2023 12:42:06 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

Kahonnohak
Kahonnohak approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked! thank you!

impelcrypto
impelcrypto approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@impelcrypto impelcrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@bobo-k2 bobo-k2 merged commit 6c9e861 into main Jan 16, 2023
@bobo-k2 bobo-k2 deleted the fix/weight-v2-issue-on-claim branch January 16, 2023 16:10
@bobo-k2 bobo-k2 mentioned this pull request Feb 1, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@impelcrypto impelcrypto impelcrypto approved these changes

@Kahonnohak Kahonnohak Kahonnohak approved these changes

@sirius651 sirius651 sirius651 approved these changes

@niklabh niklabh niklabh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bobo-k2 @niklabh @sirius651 @Kahonnohak @impelcrypto