Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move stake implementtion #1446

Merged
merged 10 commits into from
Mar 4, 2025
Merged

Move stake implementtion #1446

merged 10 commits into from
Mar 4, 2025

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Feb 21, 2025

Pull Request Summary
Support for move_stake runtime call which enables unstaking from dApp A and staking to dApp B without loosing bonus.
To initiate stake move go to Assets page and under My Dapps click Move icon for the dApp you want to move stakes from
image

Before we simulating move by unstaking from one and staking to another dApp. I replaced that logic with move_stake call.

More info about the call can be found on links below
dAppStaking - Bonus rewards mechanism rework · Issue #1379 · AstarNetwork/Astar
feat(dAppStaking): Move actions for bonus rewards by Dinonard · Pull Request #1418 · AstarNetwork/Astar

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

This pull request makes the following changes:

Copy link

github-actions bot commented Feb 21, 2025

Visit the preview URL for this PR (updated for commit 605b6a5):

https://astar-apps--pr1446-feat-move-stake-r9yjzoic.web.app

(expires Fri, 07 Mar 2025 14:40:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@bobo-k2 bobo-k2 marked this pull request as ready for review February 24, 2025 10:09
Copy link
Member

@impelcrypto impelcrypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works!

@Kahonnohak
Copy link
Contributor

Kahonnohak commented Feb 26, 2025

  1. Lets remove 3 steps from Move UI. This is less important for Move function.
Screenshot 2025-02-26 at 13 27 40
  1. Can we change styling here to have border: 1px solid #080f2e rather than white background. (So input area is more visible)
Screenshot 2025-02-26 at 13 31 29

3) We can use this area for Voting period (since no rewards) to give all notification, I'll create examples

  1. instead of 3), we can use this section
Screenshot 2025-02-26 at 14 09 59

@bobo-k2 bobo-k2 changed the base branch from main to release-hotfix February 27, 2025 08:52
@Kahonnohak
Copy link
Contributor

hm I did try to leave 2ASTR and all tokens were moved after all but I did not see a notification for this.

Screenshot 2025-02-28 at 10 58 56

@bobo-k2
Copy link
Contributor Author

bobo-k2 commented Feb 28, 2025

Nice catch. Fixed

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobo-k2 bobo-k2 merged commit 81558bb into release-hotfix Mar 4, 2025
5 of 6 checks passed
@bobo-k2 bobo-k2 deleted the feat/move-stake branch March 4, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants