Account NFT loading fix #1434
Merged
Account NFT loading fix #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 68055f7): https://astar-apps--pr1434-fix-accounts-loading-aomy95ne.web.app (expires Thu, 09 Jan 2025 14:25:15 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
gtg7784
approved these changes
Jan 3, 2025
impelcrypto
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
When we are implemented account unification on Shibuya we tried to load an account owned NFT from Token API as avatar. If error happens while fetching from the API accounts were not shown.
This PR fixes the above behaviour
UPDATE
Just found out that Bluez is deprecating all their services. Since we are using their API for NFT fetching I commented out the code until find out other provider
Check list