APR calculation fix to use block time for a given block #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 040647f): https://astar-apps--pr1389-fix-past-block-time-op10c16r.web.app (expires Tue, 01 Oct 2024 14:04:53 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
gtg7784
reviewed
Sep 25, 2024
| public async getBlockTimeInSeconds(blockNumber?: number): Promise<number> { | ||
| const api = await this.api.getApi(blockNumber); | ||
|
|
||
| if (api.consts.aura) { |
There was a problem hiding this comment.
is it means that the async backing enabled?
There was a problem hiding this comment.
Actually this means that aura pallet is not present on chain, which is the case if you ask for block time for some very old block.
impelcrypto
approved these changes
Sep 27, 2024
impelcrypto
pushed a commit
that referenced
this pull request
Sep 30, 2024
* Remove Age of Chronos promotion (#1386) * Fetch block time from chain (#1384) * Fetch block time to store * Apr calculation fix * Type fix * PR comments fix and code cleanup * Fix/selected dapp index (#1387) * Voting wizard search bug fix * Keep selected dApps while switching categories * APR calculation fix to use block time for a given block (#1389) * APR calculation fix to use block time for a given block * Small fix
impelcrypto
pushed a commit
that referenced
this pull request
Oct 1, 2024
* Remove Age of Chronos promotion (#1386) * Fetch block time from chain (#1384) * Fetch block time to store * Apr calculation fix * Type fix * PR comments fix and code cleanup * Fix/selected dapp index (#1387) * Voting wizard search bug fix * Keep selected dApps while switching categories * APR calculation fix to use block time for a given block (#1389) * APR calculation fix to use block time for a given block * Small fix * Fix for re-staking on unregistered dApps (#1392)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
I made an oversight in #1384 when I forgot to provide block number when fetching block time in APR calculations
Check list