Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove deprecated functionality #999

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Conversation

ashutoshvarma
Copy link
Member

@ashutoshvarma ashutoshvarma commented Aug 9, 2023

Pull Request Summary
remove deprecated functionality

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • updated spec version
  • updated semver

remove deprecated custom signaturee pallet
@ashutoshvarma ashutoshvarma added shiden related to shiden runtime astar Related to Astar shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. breaksapi The PR/issue is related to change that break api. labels Aug 9, 2023
Dinonard
Dinonard previously approved these changes Sep 21, 2023
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pallet doesn't even have StorageVersion - but at least we don't have to clean it up now 🙂

Copy link
Member

@shaunxw shaunxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the pallet itself should also be removed.

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
chain-extensions/types/xvm/src 0% 0%
chain-extensions/types/dapps-staking/src 0% 0%
precompiles/utils/macro/src 0% 0%
pallets/collator-selection/src 69% 0%
chain-extensions/pallet-assets/src 0% 0%
precompiles/dapps-staking/src 93% 0%
precompiles/substrate-ecdsa/src 78% 0%
precompiles/xvm/src 75% 0%
chain-extensions/xvm/src 0% 0%
pallets/xvm/src 40% 0%
precompiles/batch/src 80% 0%
primitives/src 65% 0%
pallets/dapps-staking/src/pallet 85% 0%
pallets/dapps-staking/src 81% 0%
chain-extensions/dapps-staking/src 0% 0%
precompiles/xcm/src 84% 0%
primitives/src/xcm 66% 0%
pallets/ethereum-checked/src 48% 0%
precompiles/assets-erc20/src 76% 0%
precompiles/utils/src/testing 62% 0%
pallets/block-reward/src 85% 0%
pallets/pallet-xcm/src 53% 0%
precompiles/utils/src 68% 0%
precompiles/sr25519/src 79% 0%
pallets/contracts-migration/src 0% 0%
pallets/xc-asset-config/src 53% 0%
chain-extensions/types/assets/src 0% 0%
Summary 57% (2527 / 4423) 0% (0 / 0)

Minimum allowed line rate is 50%

@ashutoshvarma ashutoshvarma merged commit ac29f4d into master Sep 25, 2023
@ashutoshvarma ashutoshvarma deleted the feat/remove-deprecated branch September 25, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar breaksapi The PR/issue is related to change that break api. runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants