Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pallet state trie migration integration #927

Merged
merged 8 commits into from
May 9, 2023
Merged

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented May 5, 2023

Pull Request Summary

Integrates pallet-state-trie-migration into all our runtimes.

Check list

  • decide on the migration account
  • updated spec version
  • updated semver

Dinonard added 5 commits May 5, 2023 10:49

Verified

This commit was signed with the committer’s verified signature.
Dinonard Dino Pačandi

Verified

This commit was signed with the committer’s verified signature.
Dinonard Dino Pačandi

Verified

This commit was signed with the committer’s verified signature.
Dinonard Dino Pačandi

Verified

This commit was signed with the committer’s verified signature.
Dinonard Dino Pačandi

Verified

This commit was signed with the committer’s verified signature.
Dinonard Dino Pačandi
@shunsukew
Copy link
Member

Which config can stop on_initialize from being executed?

@Dinonard
Copy link
Member Author

Dinonard commented May 8, 2023

Which config can stop on_initialize from being executed?

No config, it's a DB value.
It's disabled by default.

Dinonard added 3 commits May 8, 2023 16:34

Verified

This commit was signed with the committer’s verified signature.
Dinonard Dino Pačandi

Verified

This commit was signed with the committer’s verified signature.
Dinonard Dino Pačandi

Verified

This commit was signed with the committer’s verified signature.
Dinonard Dino Pačandi
@Dinonard Dinonard marked this pull request as ready for review May 8, 2023 16:00
@Dinonard
Copy link
Member Author

Dinonard commented May 8, 2023

@shunsukew tested the new account, should be ready to go 👍

@Dinonard Dinonard merged commit e84e0c8 into master May 9, 2023
@Dinonard Dinonard deleted the feat/state-migration branch May 9, 2023 06:52
@shaunxw
Copy link
Member

shaunxw commented May 9, 2023

Sorry for the late comment. Just a quick question, do we need to kill the storages in pallet-state-trie-migration after it's done and removed from runtime?

@Dinonard Dinonard added the runtime This PR/Issue is related to the topic “runtime”. label May 9, 2023
@Dinonard
Copy link
Member Author

Sorry for the late comment. Just a quick question, do we need to kill the storages in pallet-state-trie-migration after it's done and removed from runtime?

Missed the comment yesterday - you're right, since there's no call to cleanup storage items :(.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants