Add ProposerFactory limits to the cli
#893
Conversation
bin/collator/src/cli.rs
Outdated
|
|
||
| /// Proposer's maximum block size limit in bytes | ||
| #[clap(long)] | ||
| pub proposer_block_size_limit: Option<usize>, |
There was a problem hiding this comment.
What’s about to have default values (based on relay expectations)?
There was a problem hiding this comment.
For DEFAULT_BLOCK_SIZE_LIMIT this is doable. Unfortunately DEFAULT_SOFT_DEADLINE_PERCENT is not public. Of course, I can set the default_value by hand, but it would not be great IMO.
There was a problem hiding this comment.
I mean, sure, we can do something like this:
/// Proposer's maximum block size limit in bytes
#[clap(long, default_value = sc_basic_authorship::DEFAULT_BLOCK_SIZE_LIMIT)]
pub proposer_block_size_limit: usize,
/// Proposer's soft deadline in percents of block size
#[clap(long, default_value = 50)]
pub proposer_soft_deadline_percent: u8,But that can be problematic if Parity would change the constant under the hood (say to 75) but we would still pass the original value by default.
There was a problem hiding this comment.
Looks good up to me, let's use it
| @@ -1,6 +1,6 @@ | |||
| [package] | |||
| name = "astar-collator" | |||
| version = "5.1.0" | |||
There was a problem hiding this comment.
You should bump all the runtime versions too.
There was a problem hiding this comment.
@0x7CFE please fix it, double check and it looks collator version keep 5.1 while runtimes are 5.2
|
@0x7CFE please call |
|
Because of frontier patch update please bump spec versions of runtimes too |
|
@akru why did you merge the branch? I still neither updated the versions nor dependencies 🤷 |
Pull Request Summary
Check list