Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pallet contracts on Astar #891

Merged
merged 4 commits into from
Mar 29, 2023
Merged

Pallet contracts on Astar #891

merged 4 commits into from
Mar 29, 2023

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Mar 22, 2023 •
edited
Loading

Pull Request Summary

Adds pallet-contracts to Astar.

Cleans some code from Shiden and Shibuya related to pallet-contracts (minor).

Check list

  • updated spec version
  • updated semver

@Dinonard Dinonard requested review from PierreOssun and akru March 22, 2023 10:04
PierreOssun
PierreOssun reviewed Mar 22, 2023
View reviewed changes
runtime/local/src/lib.rs Show resolved Hide resolved
runtime/shiden/src/lib.rs Show resolved Hide resolved
PierreOssun
PierreOssun approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@PierreOssun PierreOssun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dinonard Dinonard merged commit 5bd0ba9 into master Mar 29, 2023
@Dinonard Dinonard deleted the feat/astar-contracts branch March 29, 2023 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreOssun PierreOssun PierreOssun approved these changes

@akru akru akru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dinonard @akru @PierreOssun