Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add collator selection pallet to benchmarks #812

Merged
merged 2 commits into from
Jan 23, 2023
Merged

add collator selection pallet to benchmarks #812

merged 2 commits into from
Jan 23, 2023

Conversation

shunsukew
Copy link
Member

@shunsukew shunsukew commented Jan 3, 2023 •
edited
Loading

Pull Request Summary
Added collator selection pallet to benchmarks so that we can benchmark this pallet by using astar-collator bin.
Once this is merged, a followup to update its weight here comes AstarNetwork/astar-frame#123

@shunsukew shunsukew requested a review from Dinonard January 3, 2023 07:06
@shunsukew shunsukew marked this pull request as ready for review January 3, 2023 07:06
@shunsukew shunsukew requested review from 0x7CFE and akru January 3, 2023 07:06
Dinonard
Dinonard reviewed Jan 3, 2023
View reviewed changes
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not immediately run the benchmarks and update the weights?

@shunsukew
Copy link
Member Author

Why not immediately run the benchmarks and update the weights?

Because we're using weights defined in astar-frame for collator-selection pallet. It will be separated PR in different repo anyway.

@shunsukew
Copy link
Member Author

shunsukew commented Jan 3, 2023 •
edited
Loading

But as you mentioned, we can go astar-frame repo updates first then update dependency here.
Until astar-frame weights updates/PR merge, I can make this draft PR if you agree

@Dinonard
Copy link
Member

Dinonard commented Jan 3, 2023

But as you mentioned, we can go astar-frame repo updates first then update dependency here. Until astar-frame weights updates/PR merge, I can make this draft PR if you agree

Yes, personally I prefer to do it with less PRs. It will go faster.
Up to you though.

@shunsukew shunsukew marked this pull request as draft January 3, 2023 10:21
@shunsukew shunsukew marked this pull request as ready for review January 18, 2023 03:09
@shunsukew shunsukew requested a review from Dinonard January 18, 2023 03:10
@shunsukew
Copy link
Member Author

Executed cargo update -p pallet-collator-selection to includes new weights merged in astar-frame polkadot-v0.9.33 branch.

@shunsukew shunsukew merged commit 71eb5b7 into master Jan 23, 2023
@shunsukew shunsukew deleted the add-collator-selection-benchmarks branch January 23, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akru akru akru approved these changes

@0x7CFE 0x7CFE Awaiting requested review from 0x7CFE

@Dinonard Dinonard Awaiting requested review from Dinonard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shunsukew @Dinonard @akru