Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for zero era problem #477

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Oct 13, 2021

Checklist

  • all tests passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • changed API client type definition or chain metadata

Affected core subsystem(s)

Dapps staking

Description of change

Fixed an issue where 1st era wouldn't be triggered if dapps staking
is enabled in mid of what would numerically be an era.

This caused some storage to remain uninitialized which caused dapps staking not to work properly.


@Dinonard Dinonard requested review from hoonsubin, akru and Maar-io and removed request for hoonsubin, akru and Maar-io October 13, 2021 15:36
Copy link
Contributor

@akru akru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump runtime and pallet versions because of changed behavior

@Dinonard
Copy link
Member Author

All versions bumped up now.

@akru
Copy link
Contributor

akru commented Oct 13, 2021

@Dinonard please update Cargo.lock too

@Dinonard
Copy link
Member Author

🙈

@Dinonard
Copy link
Member Author

@akru is it ok now?

Copy link
Contributor

@akru akru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update versions and merge

@Dinonard Dinonard force-pushed the dapps-staking/fix-for-zero-era branch from de707ce to 96fcc64 Compare October 25, 2021 17:25
Copy link
Contributor

@akru akru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you

@Dinonard Dinonard merged commit 8656a4f into development/shiden Oct 26, 2021
@Dinonard Dinonard deleted the dapps-staking/fix-for-zero-era branch October 26, 2021 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants