OVMi Part2 AtomicPredicates #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akru
suggested changes
May 15, 2020
ovmi/lib/src/predicates/equal.rs
Outdated
|
|
||
| impl<'a, Ext: ExternalCall> AtomicPredicateInterface<AddressOf<Ext>> for EqualPredicate<'a, Ext> { | ||
| fn decide(&self, inputs: Vec<Vec<u8>>) -> ExecResult<AddressOf<Ext>> { | ||
| println!( |
There was a problem hiding this comment.
oh..
That's a mistake to remove.
| use crate::Range; | ||
|
|
||
| pub struct IsLessThanPredicate<'a, Ext: ExternalCall> { | ||
| pub ext: &'a Ext, |
There was a problem hiding this comment.
What's about to use Arc here instead of a specified lifetime? In my view 'a makes interface a bit dirty.
| use crate::Range; | ||
|
|
||
| pub struct IsValidSignaturePredicate<'a, Ext: ExternalCall> { | ||
| pub ext: &'a Ext, |
|
@akru Please let me know if you have any problems. |
akru
reviewed
May 15, 2020
satellitex
added a commit
that referenced
this pull request
Jul 8, 2020
* Dusty chainspec upgrade (#155) * Plasm Network mainnet (#149) * Plasm Network mainnet genesis * Bump frame modules * Added mainnet genesis into subkey * Added bootnodes * Bump version in README * Create feature_task.md (#150) * Create feature_task.md * Rename feature_task.md to future_task.md * Update future_task.md * Update feature_request.md * Update feature_request.md * Update future_task.md * Update chainspec: dusty2 * fix fmt Co-authored-by: satellitex <[email protected]> * update reward functionality * apply formatting * use mutate * separate claim into two methods * modify tests * fix overflow * check if era is valid * add doc comments * OVMi Part2 AtomicPredicates (#154) * WIP: or decidable * add or * ovm ext_call is not needed mut * add all logical and deciable predicates * WIP: eq * add AtomicPredicates * fmt and add lock * add from_address to executable predicate * add predicate mock * fmt * add tests * add from_address to executable predicate * upd lock * tmp * fix name * WIP: is valid signature * lifetime * fix lifetime 2 * add staking amounts for each operator * Plasm lockdrop oracle requests refactoring (#158) * Using localhost oracle for lockdrop module * Added small https proxy helper * Disable lockdrop oracle by default * Fix fmt * Add claim into subkey (#164) * add claim into subkey g * use inspect * fix use v * reverse use plasm * Plasma module Part1 (#162) * WIP: plasma module * build passed template * add submit root * add deploy and first test * success submit_root test * passed build commitment * add rpc call for plasma * fix for plasm hashing * add describe plapps_hash * Upgrade Plasm Node up to substrate 2.0-rc2 (#170) * Upgrade to substrate 2.0-rc2 * Fix unused imports * enable dapps staking * Feature plasma deposit (#171) * add deposit * passed build * add finalize_checkpoint * WIP: bare_finalize_exit * WIP deserializer * WIP: add modules * WIP * pssed build * WIP: fix weight * fix ovm and plasma * passed deposit test * WIP: plasm-deposit * WIP fix range * passed until xxx * assed without finalized * fix passed test * fix docker builder (#176) * Dusty release 1.1.0 (#174) * Bump version, fix chain specs * Added legacy storage runtime interface * Using default child for legacy calls * Fix compilation & format * Bump subkey version * [CI]: bump nix actions version * Fix implementation name Co-authored-by: satellitex <[email protected]> Co-authored-by: t8m8 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#153
Implement about
BaseAtomicPredicates.without using signature.(
verify_inclusionandis_valid_sginature)Dependencies
Signatures are handled in a separate PR, as there is a dependency PR here.
paritytech/substrate#6029
Checklist
Affected core subsystem(s)
Description of change