-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/evm fee burning #1390
Merged
Merged
Fix/evm fee burning #1390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipapandinas
previously approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate both OnUnbalanced
handlers is a good design! The naming of OUF
and OUT
could be improved for clarity, for example: FeeHandler
and TipHandler
but it's really minor.
LGTM
Sure, I'll rename the types. |
ermalkaleci
previously approved these changes
Dec 4, 2024
Dinonard
dismissed stale reviews from ermalkaleci and ipapandinas
via
December 5, 2024 13:34
4cb2f41
Minimum allowed line rate is |
ermalkaleci
approved these changes
Dec 5, 2024
ipapandinas
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Fixes an inconsistency where EVM fees would be handled differently compared to the native fees.
This PR ensures that 80% of the fees are burned, while the tip goes 100% into the collator reward pot.