Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime genesis generation #1341

Merged
merged 17 commits into from
Aug 29, 2024
Merged

Runtime genesis generation #1341

merged 17 commits into from
Aug 29, 2024

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Aug 27, 2024

Summary

  • move the genesis generation into the runtime itself
    • previously this was dummy code which returned None
  • remove genesis generation from the client code
  • introduces development profile Id, which is by default expected when running benchmarks
  • introduces genesis and parachain primitives modules to reduce code duplication

This is a step towards decoupling client from the runtime code.
Client still relies on the runtime crates to acquire the WASM blob & generate genesis.

The frame-omni-bencher tool still cannot be used properly in case repeat param is set to be larger than 1.
It's a known issue and should be resolved with this PR: paritytech/polkadot-sdk#5083

@Dinonard Dinonard added shiden related to shiden runtime astar Related to Astar shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. client This PR/Issue is related to the topic “client”. labels Aug 28, 2024
@Dinonard Dinonard marked this pull request as ready for review August 28, 2024 14:39
@ermalkaleci
Copy link
Contributor

@Dinonard can you resolve conflicts?

ermalkaleci
ermalkaleci previously approved these changes Aug 29, 2024
@Dinonard
Copy link
Member Author

/bench astar-dev,shibuya-dev,shiden-dev pallet_dapp_staking

Copy link

Code Coverage

Package Line Rate Branch Rate Health
precompiles/dispatch-lockdrop/src 86% 0%
primitives/src/xcm 65% 0%
pallets/dapp-staking/src 83% 0%
pallets/xc-asset-config/src 50% 0%
precompiles/xcm/src 71% 0%
pallets/dapp-staking/src/benchmarking 98% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/dapp-staking/rpc/runtime-api/src 0% 0%
primitives/src 57% 0%
chain-extensions/pallet-assets/src 56% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/inflation/src 93% 0%
precompiles/assets-erc20/src 78% 0%
pallets/collator-selection/src 92% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/dapp-staking/src/test 0% 0%
pallets/ethereum-checked/src 74% 0%
precompiles/sr25519/src 64% 0%
chain-extensions/types/assets/src 0% 0%
pallets/collective-proxy/src 86% 0%
precompiles/unified-accounts/src 100% 0%
precompiles/dapp-staking/src 90% 0%
pallets/astar-xcm-benchmarks/src 86% 0%
pallets/unified-accounts/src 86% 0%
pallets/price-aggregator/src 82% 0%
pallets/static-price-provider/src 85% 0%
chain-extensions/types/unified-accounts/src 0% 0%
precompiles/dapp-staking/src/test 0% 0%
Summary 79% (3649 / 4620) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10611955304.
Please wait for a while.
Branch: feat/runtime-genesis-generation
SHA: 4eb3640

Copy link
Contributor

@ipapandinas ipapandinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This closes #1336

@ipapandinas ipapandinas linked an issue Aug 29, 2024 that may be closed by this pull request
2 tasks
Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/10611955304.

@Dinonard Dinonard merged commit cc87612 into master Aug 29, 2024
8 checks passed
@Dinonard Dinonard deleted the feat/runtime-genesis-generation branch August 29, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar client This PR/Issue is related to the topic “client”. runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move genesis config in runtime and organize variants with presets
3 participants