-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Runtime genesis generation #1341
Conversation
@Dinonard can you resolve conflicts? |
/bench astar-dev,shibuya-dev,shiden-dev pallet_dapp_staking |
Minimum allowed line rate is |
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10611955304. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This closes #1336 ✨
Benchmarks have been finished. |
Summary
None
development
profile Id, which is by default expected when running benchmarksgenesis
andparachain
primitives modules to reduce code duplicationThis is a step towards decoupling client from the runtime code.
Client still relies on the runtime crates to acquire the WASM blob & generate genesis.
The
frame-omni-bencher
tool still cannot be used properly in caserepeat
param is set to be larger than 1.It's a known issue and should be resolved with this PR: paritytech/polkadot-sdk#5083