-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prep v5.43.0 #1323
prep v5.43.0 #1323
Conversation
LGTM - just a question about EVM tracing. Since Just to keep in mind:
|
They should not do it automatically. Not every release goes on-chain |
We can bump runtime as well and not upgrade until we do further testing. I want client out so we solve missed blocks |
Not sure what to say about this tbh - I'd prefer if it was automated, at least to some degree. |
evm-tracing node needs to be updated only when there's new runtime upgrade |
@Dinonard I'm fine with bumping spec_version |
@Dinonard bumped |
/runtime-upgrade-test shibuya |
/runtime-upgrade-test shiden |
/runtime-upgrade-test astar |
Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10321112432. |
Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10321114844. |
Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10321113307. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Runtime upgrade test finished: yarn run v1.22.22 RUN v1.6.0 /home/runner/work/Astar/Astar/tests/e2e ✓ tests/runtime-upgrade.test.ts (1 test) 40982ms Test Files 1 passed (1) Done in 45.48s. |
Minimum allowed line rate is |
Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10321112432. |
Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10321114844. |
Pull Request Summary
Prepare new client & runtime release