-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-block migrator #1322
Multi-block migrator #1322
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, my only real concern is the question about EnterSafeModeOnFailedMigration
.
/runtime-upgrade-test astar |
/runtime-upgrade-test shiden |
/runtime-upgrade-test shibuya |
Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10384640871. |
Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10384645075. |
Runtime upgrade test is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/10384646602. |
Runtime upgrade test finished: yarn run v1.22.22 RUN v2.0.5 /home/runner/work/Astar/Astar/tests/e2e ✓ tests/runtime-upgrade.test.ts (1 test) 76407ms Test Files 1 passed (1) Done in 81.91s. |
Runtime upgrade test finished: yarn run v1.22.22 RUN v2.0.5 /home/runner/work/Astar/Astar/tests/e2e ✓ tests/runtime-upgrade.test.ts (1 test) 263066ms Test Files 1 passed (1) Done in 269.20s. |
Runtime upgrade test finished: yarn run v1.22.22 RUN v2.0.5 /home/runner/work/Astar/Astar/tests/e2e ✓ tests/runtime-upgrade.test.ts (1 test) 255889ms Test Files 1 passed (1) Done in 262.77s. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Minimum allowed line rate is |
Pull Request Summary
Add multi-block migration pallet.
Re-structure migration definition.
Service weight is set to 50% because only inherent extrinsic are applied during migrations. Almost entire block is dedicated to migrations.