Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor governance param adjustment #1296

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

Dinonard
Copy link
Member

Pull Request Summary

Adjusted local runtime params to make testing scenarios described in the docs easier.
Current timing was sometimes too fast, which made it difficult to detect certain changes.

Also added missing settings for Shibuya runtime in respect with setting oracle members.
Slightly modified timing params for democracy.

@Dinonard Dinonard added shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels Jul 12, 2024
Copy link

Code Coverage

Package Line Rate Branch Rate Health
chain-extensions/types/assets/src 0% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/xvm/src 54% 0%
pallets/static-price-provider/src 52% 0%
precompiles/dapp-staking-v3/src 90% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
precompiles/unified-accounts/src 100% 0%
pallets/collator-selection/src 92% 0%
precompiles/xcm/src 73% 0%
primitives/src/xcm 64% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/oracle-benchmarks/src 0% 0%
precompiles/dispatch-lockdrop/src 86% 0%
pallets/collective-proxy/src 86% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
precompiles/assets-erc20/src 81% 0%
pallets/ethereum-checked/src 79% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/price-aggregator/src 72% 0%
pallets/astar-xcm-benchmarks/src 88% 0%
pallets/inflation/src 83% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
pallets/xc-asset-config/src 64% 0%
pallets/dapp-staking-v3/src 90% 0%
chain-extensions/xvm/src 0% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/unified-accounts/src 86% 0%
precompiles/substrate-ecdsa/src 74% 0%
precompiles/xvm/src 75% 0%
precompiles/sr25519/src 64% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
pallets/dapp-staking-migration/src 0% 0%
pallets/dapp-staking-v3/src/test 0% 0%
primitives/src 62% 0%
Summary 77% (3704 / 4796) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard Dinonard requested a review from ermalkaleci July 12, 2024 12:51
@Dinonard Dinonard merged commit b9e79fe into master Jul 12, 2024
10 checks passed
@Dinonard Dinonard deleted the feat/governance-params-adjustment branch July 12, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants