add candidacy un-bonding period

[ermalkaleci]

Pull Request Summary

https://forum.astar.network/t/collator-candidacy-un-bonding-period/7019

• Modified call leave_intent to remove candidacy and start unbondig process.
• Add call withdraw_bond to withdraw CandidacyBond after on next session.
• Some refactoring/cleanup to make code more readable

[ermalkaleci]

/bench astar-dev,shibuya-dev,shiden-dev pallet-collator-selection

[github-actions]

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9684829218.
Please wait for a while.
Branch: feat/improve-collator-selection
SHA: 2e6a63a

[ermalkaleci]

/bench astar-dev,shibuya-dev,shiden-dev pallet-collator-selection

[github-actions]

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/9684943439.
Please wait for a while.
Branch: feat/improve-collator-selection
SHA: 2e6a63a

[github-actions]

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/9684943439.

[Dinonard]

Looks good, just a few minor comments.

[github-actions]

Package	Line Rate	Branch Rate	Health
pallets/inflation/src	83%	0%	✔
primitives/src	62%	0%	➖
chain-extensions/unified-accounts/src	0%	0%	❌
pallets/dapp-staking-v3/src	90%	0%	✔
pallets/astar-xcm-benchmarks/src/generic	100%	0%	✔
chain-extensions/types/assets/src	0%	0%	❌
precompiles/dispatch-lockdrop/src	86%	0%	✔
pallets/dapp-staking-v3/src/test	0%	0%	❌
pallets/dapp-staking-migration/src	0%	0%	❌
precompiles/xvm/src	75%	0%	➖
precompiles/sr25519/src	64%	0%	➖
pallets/astar-xcm-benchmarks/src/fungible	100%	0%	✔
pallets/xvm/src	54%	0%	➖
precompiles/unified-accounts/src	100%	0%	✔
pallets/xc-asset-config/src	64%	0%	➖
precompiles/substrate-ecdsa/src	74%	0%	➖
precompiles/dapp-staking-v3/src	90%	0%	✔
precompiles/assets-erc20/src	81%	0%	✔
pallets/collective-proxy/src	86%	0%	✔
pallets/dynamic-evm-base-fee/src	89%	0%	✔
pallets/price-aggregator/src	72%	0%	➖
chain-extensions/xvm/src	0%	0%	❌
pallets/static-price-provider/src	52%	0%	➖
pallets/astar-xcm-benchmarks/src	88%	0%	✔
primitives/src/xcm	64%	0%	➖
chain-extensions/types/xvm/src	0%	0%	❌
chain-extensions/types/unified-accounts/src	0%	0%	❌
pallets/collator-selection/src	92%	0%	✔
chain-extensions/pallet-assets/src	56%	0%	➖
pallets/dapp-staking-v3/rpc/runtime-api/src	0%	0%	❌
pallets/ethereum-checked/src	79%	0%	➖
precompiles/dapp-staking-v3/src/test	0%	0%	❌
pallets/oracle-benchmarks/src	0%	0%	❌
precompiles/xcm/src	73%	0%	➖
pallets/dapp-staking-v3/src/benchmarking	98%	0%	✔
pallets/unified-accounts/src	86%	0%	✔
Summary	77% (3704 / 4796)	0% (0 / 0)	➖

Minimum allowed line rate is 50%

[Dinonard]

LGTM!