Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert node id #1280

Merged
merged 1 commit into from
Jun 25, 2024
Merged

revert node id #1280

merged 1 commit into from
Jun 25, 2024

Conversation

mc2eqe
Copy link
Contributor

@mc2eqe mc2eqe commented Jun 25, 2024

Wrong node ID set on boot node shibuya 03. We need to revert the old node id setup.

Pull Request Summary

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • added benchmarks & weights for any modified runtime logics.

@mc2eqe mc2eqe added bug Something isn't working shibuya related to shibuya labels Jun 25, 2024
@mc2eqe mc2eqe requested review from Dinonard and bLd75 June 25, 2024 11:38
@mc2eqe mc2eqe self-assigned this Jun 25, 2024
@mc2eqe mc2eqe added the client This PR/Issue is related to the topic “client”. label Jun 25, 2024
@Dinonard Dinonard merged commit 0bd932d into master Jun 25, 2024
8 of 12 checks passed
@Dinonard Dinonard deleted the fix/shibuya-boot-node-03 branch June 25, 2024 11:54
Copy link

Code Coverage

Package Line Rate Branch Rate Health
chain-extensions/types/unified-accounts/src 0% 0%
primitives/src/xcm 64% 0%
chain-extensions/xvm/src 0% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/static-price-provider/src 52% 0%
pallets/oracle-benchmarks/src 0% 0%
pallets/xc-asset-config/src 64% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/dapp-staking-v3/src/test 0% 0%
pallets/ethereum-checked/src 79% 0%
precompiles/assets-erc20/src 81% 0%
pallets/dapp-staking-v3/src 90% 0%
precompiles/substrate-ecdsa/src 74% 0%
precompiles/xcm/src 73% 0%
precompiles/dapp-staking-v3/src 90% 0%
primitives/src 62% 0%
pallets/dynamic-evm-base-fee/src 89% 0%
chain-extensions/types/assets/src 0% 0%
precompiles/unified-accounts/src 100% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
precompiles/sr25519/src 64% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/dapp-staking-migration/src 0% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/inflation/src 83% 0%
pallets/price-aggregator/src 72% 0%
precompiles/dispatch-lockdrop/src 86% 0%
pallets/collator-selection/src 91% 0%
pallets/unified-accounts/src 86% 0%
pallets/xvm/src 54% 0%
pallets/astar-xcm-benchmarks/src 88% 0%
precompiles/xvm/src 75% 0%
Summary 77% (3650 / 4735) 0% (0 / 0)

Minimum allowed line rate is 50%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client This PR/Issue is related to the topic “client”. shibuya related to shibuya
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants