Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha check migrations #1254

Merged
merged 6 commits into from
Jun 5, 2024
Merged

gha check migrations #1254

merged 6 commits into from
Jun 5, 2024

Conversation

ermalkaleci
Copy link
Contributor

No description provided.

@ermalkaleci ermalkaleci added the ci This PR/Issue is related to the topic "CI" label Jun 5, 2024
@ermalkaleci ermalkaleci requested a review from Dinonard June 5, 2024 08:48
Copy link

github-actions bot commented Jun 5, 2024

Code Coverage

Package Line Rate Branch Rate Health
precompiles/xcm/src 73% 0%
precompiles/dapp-staking-v3/src 90% 0%
precompiles/xvm/src 75% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/price-aggregator/src 72% 0%
pallets/dapp-staking-v3/src 92% 0%
pallets/xc-asset-config/src 64% 0%
primitives/src 61% 0%
chain-extensions/xvm/src 0% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
pallets/dapp-staking-migration/src 0% 0%
chain-extensions/types/assets/src 0% 0%
pallets/xvm/src 54% 0%
precompiles/assets-erc20/src 81% 0%
chain-extensions/pallet-assets/src 56% 0%
precompiles/sr25519/src 64% 0%
pallets/collator-selection/src 92% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
primitives/src/xcm 64% 0%
pallets/astar-xcm-benchmarks/src 88% 0%
precompiles/dispatch-lockdrop/src 86% 0%
pallets/ethereum-checked/src 79% 0%
pallets/static-price-provider/src 52% 0%
pallets/unified-accounts/src 86% 0%
chain-extensions/unified-accounts/src 0% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/dapp-staking-v3/src/test 0% 0%
pallets/inflation/src 83% 0%
chain-extensions/types/xvm/src 0% 0%
precompiles/unified-accounts/src 100% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/oracle-benchmarks/src 0% 0%
Summary 78% (3600 / 4635) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

run: rustup target list --installed

- name: Build EXTRA_ARGS
if: ${{ !startsWith(github.ref, 'refs/tags/v') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed since you already check it as the entry condition for the script to run?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's needed. It shouldn't check spec version unless you're releasing. This will run on master or manually triggered to your branch

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, thanks!

@ermalkaleci ermalkaleci merged commit a64276f into master Jun 5, 2024
8 checks passed
@ermalkaleci ermalkaleci deleted the feat/check-migrations branch June 5, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This PR/Issue is related to the topic "CI"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants