Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontier RPC tests #1249

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Frontier RPC tests #1249

merged 6 commits into from
Jun 4, 2024

Conversation

ermalkaleci
Copy link
Contributor

@ermalkaleci ermalkaleci commented May 23, 2024

Add feature to enable manual sealing for local chain only.
Github action to run frontier RPC tests on PR or master merge.
Tests are moved here with slight modification to work on our environment.

@ermalkaleci ermalkaleci added the ci This PR/Issue is related to the topic "CI" label May 23, 2024
@ermalkaleci ermalkaleci marked this pull request as ready for review May 24, 2024 10:22
Copy link

github-actions bot commented Jun 4, 2024

Code Coverage

Package Line Rate Branch Rate Health
pallets/static-price-provider/src 52% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/astar-xcm-benchmarks/src 88% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
precompiles/assets-erc20/src 81% 0%
pallets/unified-accounts/src 86% 0%
pallets/inflation/src 83% 0%
pallets/xvm/src 54% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
precompiles/sr25519/src 64% 0%
chain-extensions/types/xvm/src 0% 0%
primitives/src 61% 0%
pallets/dapp-staking-migration/src 0% 0%
pallets/price-aggregator/src 72% 0%
precompiles/unified-accounts/src 100% 0%
chain-extensions/unified-accounts/src 0% 0%
chain-extensions/xvm/src 0% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
precompiles/substrate-ecdsa/src 74% 0%
precompiles/dapp-staking-v3/src 90% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
pallets/dapp-staking-v3/src 92% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/ethereum-checked/src 79% 0%
precompiles/xvm/src 75% 0%
pallets/xc-asset-config/src 64% 0%
pallets/collator-selection/src 92% 0%
pallets/dapp-staking-v3/src/test 0% 0%
precompiles/xcm/src 73% 0%
pallets/oracle-benchmarks/src 0% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
chain-extensions/types/assets/src 0% 0%
precompiles/dispatch-lockdrop/src 86% 0%
chain-extensions/types/unified-accounts/src 0% 0%
primitives/src/xcm 64% 0%
Summary 78% (3600 / 4635) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just an observation, but this allows manual-seal breaking builds to be merged, prior to running this check. We could add another cargo check --features manual-seal to the CI, but not sure if that's what we want given how much time it would take to execute it.

@ermalkaleci
Copy link
Contributor Author

LGTM!

Just an observation, but this allows manual-seal breaking builds to be merged, prior to running this check. We could add another cargo check --features manual-seal to the CI, but not sure if that's what we want given how much time it would take to execute it.

If this breaks then CI will fail, we're good

@ermalkaleci ermalkaleci merged commit ab95d31 into master Jun 4, 2024
8 checks passed
@ermalkaleci ermalkaleci deleted the feat/frontier-rpc-tests branch June 4, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This PR/Issue is related to the topic "CI"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants