-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontier RPC tests #1249
Frontier RPC tests #1249
Conversation
Minimum allowed line rate is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Just an observation, but this allows manual-seal
breaking builds to be merged, prior to running this check. We could add another cargo check --features manual-seal
to the CI, but not sure if that's what we want given how much time it would take to execute it.
If this breaks then CI will fail, we're good |
Add feature to enable manual sealing for local chain only.
Github action to run frontier RPC tests on PR or master merge.
Tests are moved here with slight modification to work on our environment.