-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix shiden genesis sync #1242
fix shiden genesis sync #1242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ermalkaleci can you add a brief PR summary for root cause, solution? thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To add to Ash's comment, please add a PR summary/description so it's clear what it's about. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Left one comment, but it's optional.
However, please add a PR summary before the merge. Thanks!
Minimum allowed line rate is |
Custom PendingCrateInherentDataProvider and AuraConsensusDataProvider implementation required by EVM RPC to support Shiden sync from genesis block when there was no AuraApi. The implementation returns error instead of panic