fix(contracts): migrate CodeInfoOf<T> from Twox64Concat hashing to Identity as defined in pallet-contracts
#1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashutoshvarma
added
shiden
Dinonard
reviewed
Mar 14, 2024
primitives/src/migrations/mod.rs
Outdated
| impl<T: pallet_contracts::Config, const V: u16> OnRuntimeUpgrade for ForceContractsVersion<T, V> { | ||
| fn on_runtime_upgrade() -> Weight { | ||
| StorageVersion::new(V).put::<pallet_contracts::Pallet<T>>(); | ||
| <T as frame_system::Config>::DbWeight::get().reads_writes(1, 1) |
There was a problem hiding this comment.
Not a big deal, but isn't this a single write only?
There was a problem hiding this comment.
you are right, I'l change this
runtime/shiden/src/lib.rs
Outdated
Comment on lines
1118
to
1120
| // [contracts fix] Part of shiden-121 (added after v5.33.0 release) | ||
| astar_primitives::migrations::ForceContractsVersion<Runtime, 14>, | ||
| pallet_contracts::Migration<Runtime>, |
There was a problem hiding this comment.
If I understood correctly, this will downgrade storage version by 1, to ensure we bump it back to the correct one with the new migration, right?
Might be an overkill, but I'd add another dummy struct here that checks in try-runtime hooks that version was bumped back up to the expected one. Just a suggestion.
There was a problem hiding this comment.
Yes, that's correct.
I'll add that.
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
The release v5.33.0 included a faulty pallet-contracts migration v12 where
CodeInfoOf<T>storage item had incorrect alias.This PR includes a new migration to fix this issue. Also in order to run the migration properly we need to bring down pallet's storage version to 14.
TODO
Check list