Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/incorrect eras per cycle function #1166

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Feb 7, 2024

Pull Request Summary

Fix an issue where inflation recalculation era would be incorrectly calculated.

Instead of accounting for cycle length in era lengths, number of discreet era per cycle needs to be considered.

@Dinonard Dinonard added runtime This PR/Issue is related to the topic “runtime”. shiden related to shiden runtime labels Feb 7, 2024
@Dinonard Dinonard changed the base branch from master to feat/astar-dsv3-t2-integration February 7, 2024 14:00
@Dinonard Dinonard changed the base branch from feat/astar-dsv3-t2-integration to master February 7, 2024 14:01
@Dinonard Dinonard changed the base branch from master to feat/astar-dsv3-t2-integration February 7, 2024 14:01
@Dinonard Dinonard merged commit 8b2013c into feat/astar-dsv3-t2-integration Feb 7, 2024
11 of 13 checks passed
@Dinonard Dinonard deleted the fix/incorrect-eras-per-cycle-function branch February 7, 2024 14:21
Copy link

github-actions bot commented Feb 7, 2024

Code Coverage

Package Line Rate Branch Rate Health
pallets/dapp-staking-v3/src/test 0% 0%
pallets/static-price-provider/src 58% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/xcm/src 72% 0%
pallets/astar-xcm-benchmarks/src 89% 0%
pallets/dapps-staking/src/pallet 86% 0%
pallets/dapp-staking-migration/src 48% 0%
chain-extensions/types/xvm/src 0% 0%
precompiles/unified-accounts/src 100% 0%
primitives/src 62% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/collator-selection/src 89% 0%
pallets/dapp-staking-v3/src 88% 0%
precompiles/xvm/src 74% 0%
chain-extensions/xvm/src 0% 0%
pallets/ethereum-checked/src 75% 0%
precompiles/dapps-staking/src 94% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/block-rewards-hybrid/src 91% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
precompiles/dapp-staking-v3/src 90% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/dapps-staking/src 90% 0%
primitives/src/xcm 66% 0%
chain-extensions/types/assets/src 0% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
pallets/inflation/src 80% 0%
pallets/xc-asset-config/src 64% 0%
pallets/unified-accounts/src 84% 0%
precompiles/assets-erc20/src 81% 0%
precompiles/dispatch-lockdrop/src 86% 0%
precompiles/sr25519/src 64% 0%
pallets/xvm/src 51% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
Summary 79% (4425 / 5602) 0% (0 / 0)

Minimum allowed line rate is 50%

Dinonard added a commit that referenced this pull request Feb 9, 2024
* Integration

* Shiden cleanup

* chain spec update

* Minor changes

* Fix for incorrect eras per cycle function (#1166)

* Adjustments

* Safeguard test

* Docs

* Fixes

* Extra test

* Update weights

* Ensure benchmark tests work

* Formatting

* Init price
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”. shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants