Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orml-xtokens pallet name typo fix #1075

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

shaunxw
Copy link
Member

@shaunxw shaunxw commented Nov 1, 2023

Pull Request Summary

It is changing from Xtokens to XTokens, as other parachains commonly use the latter.

There are no storage items in orml-xtokens, so storage migration is not needed.

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • updated spec version
  • updated semver

@shaunxw shaunxw added the runtime This PR/Issue is related to the topic “runtime”. label Nov 1, 2023
Copy link

github-actions bot commented Nov 1, 2023

Code Coverage

Package Line Rate Branch Rate Health
precompiles/utils/src/testing 38% 0%
pallets/collator-selection/src 69% 0%
precompiles/xcm/src 75% 0%
precompiles/dapps-staking/src 93% 0%
pallets/unified-accounts/src 83% 0%
precompiles/sr25519/src 79% 0%
pallets/xc-asset-config/src 53% 0%
chain-extensions/pallet-assets/src 0% 0%
chain-extensions/types/assets/src 0% 0%
pallets/block-reward/src 85% 0%
precompiles/assets-erc20/src 76% 0%
primitives/src/xcm 66% 0%
pallets/dapps-staking/src 81% 0%
pallets/ethereum-checked/src 48% 0%
chain-extensions/types/dapps-staking/src 0% 0%
chain-extensions/types/unified-accounts/src 0% 0%
precompiles/utils/macro/src 0% 0%
pallets/dapps-staking/src/pallet 85% 0%
precompiles/substrate-ecdsa/src 78% 0%
chain-extensions/unified-accounts/src 0% 0%
chain-extensions/dapps-staking/src 0% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/contracts-migration/src 0% 0%
precompiles/utils/src 55% 0%
pallets/xvm/src 40% 0%
precompiles/xvm/src 75% 0%
primitives/src 65% 0%
chain-extensions/xvm/src 0% 0%
pallets/dynamic-evm-base-fee/src 81% 0%
Summary 56% (2209 / 3939) 0% (0 / 0)

Minimum allowed line rate is 50%

@ashutoshvarma ashutoshvarma added shiden related to shiden runtime astar Related to Astar shibuya related to shibuya labels Nov 1, 2023
@shaunxw shaunxw merged commit e27f0b0 into master Nov 2, 2023
11 of 12 checks passed
@shaunxw shaunxw deleted the feat/xtokens-pallet-name-typo-fix branch November 2, 2023 09:47
@shaunxw shaunxw mentioned this pull request Nov 2, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants