Fee Alignment - Shibuya/local

[Dinonard]

Pull Request Summary

This PR introduces rent fee reduction and fee alignment to local and Shibuya networks.

Pallet DynamicEvmBaseFee handles calculation and adjustment of base fee per gas parameter.
It's unlike EIP-1559, and instead uses a customized approach for Astar.
The core idea is to keep native fees & EVM fees aligned as much as possible.

For a detailed & expansive overview, please refer to Astar Forum post HERE.
Pallet rustdoc contains some more detailed description of the implementation approach.

Shibuya Integration

• even though Tokenomics params weren't intended for Shibuya, they are exactly as they will be for Astar (fee-wise)
• this is on purpose since it's a testnet
• some numbers were rounded on very small decimals to make them more readable (but it can be easily modified to be exact as in the report - feel free to comment)

Local Integration

• this runtime received a bit more modification to make it more aligned with parachain runtimes

Check list

• added or updated unit tests
• updated Astar official documentation
• reduce rent fees
• reduce WASM SC rent fees by 100x
• burn portions update
• fee alignment logic
• run & update benchmark values
• OnRuntimeUpgrade logic to modify DB adjustable params
• apply necessary changes to local runtime

[ashutoshvarma]

Great tests!

I'm not very clear about how adjustment factor will be handled, as I understand it be updated every block based on block fullness. I couldn't find any TODOs for that, will there be a new pallet for it or it'll be part of this pallet itself?

[Dinonard]

@ashutoshvarma

I'm not very clear about how adjustment factor will be handled, as I understand it be updated every block based on block fullness. I couldn't find any TODOs for that, will there be a new pallet for it or it'll be part of this pallet itself?

There's no TODO since this is already implemented & live on all of our networks.
It's part of the pallet-transaction-payment.

One of the remaining TODOs is related to this part though.
I have to check current values for the adjustment factor and see how it should be 'adjusted' so native fees don't change too much (since in Tokenomics v2 we are changing some of the constants).

[ashutoshvarma]

@Dinonard

There's no TODO since this is already implemented & live on all of our networks.
It's part of the pallet-transaction-payment.

I missed that, I assumed this 'adjustment factor' is something specific to this pallet. Now it make sense.

[shaunxw]

LGTM. Awesome docs and test coverage!

[Dinonard]

/bench shibuya-dev pallet_dynamic_evm_base_fee

[github-actions]

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/6327663494.
Please wait for a while.
Branch: feat/tokenomics-v2-fees-shibuya
SHA: a8900aa

[github-actions]

Benchmark job failed.
Please check https://github.com/AstarNetwork/Astar/actions/runs/6327663494.

[Dinonard]

/bench shibuya-dev pallet_dynamic_evm_base_fee

[github-actions]

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/6335948645.
Please wait for a while.
Branch: feat/tokenomics-v2-fees-shibuya
SHA: 32fa2b5

[github-actions]

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/6335948645.

[github-actions]

Package	Line Rate	Branch Rate	Health
pallets/collator-selection/src	69%	0%	➖
pallets/block-reward/src	85%	0%	✔
pallets/dapps-staking/src	81%	0%	✔
pallets/xc-asset-config/src	53%	0%	➖
chain-extensions/types/assets/src	0%	0%	❌
precompiles/utils/src	68%	0%	➖
pallets/contracts-migration/src	0%	0%	❌
precompiles/sr25519/src	79%	0%	➖
chain-extensions/types/xvm/src	0%	0%	❌
primitives/src	62%	0%	➖
pallets/unified-accounts/src	80%	0%	✔
chain-extensions/xvm/src	0%	0%	❌
chain-extensions/types/dapps-staking/src	0%	0%	❌
pallets/ethereum-checked/src	48%	0%	❌
precompiles/assets-erc20/src	76%	0%	➖
precompiles/dapps-staking/src	93%	0%	✔
precompiles/xvm/src	75%	0%	➖
pallets/pallet-xcm/src	53%	0%	➖
pallets/dapps-staking/src/pallet	85%	0%	✔
pallets/xvm/src	40%	0%	❌
precompiles/substrate-ecdsa/src	78%	0%	➖
pallets/dynamic-evm-base-fee/src	81%	0%	✔
precompiles/utils/src/testing	62%	0%	➖
precompiles/xcm/src	84%	0%	✔
chain-extensions/dapps-staking/src	0%	0%	❌
precompiles/utils/macro/src	0%	0%	❌
primitives/src/xcm	66%	0%	➖
chain-extensions/pallet-assets/src	0%	0%	❌
precompiles/batch/src	80%	0%	✔
Summary	58% (2652 / 4587)	0% (0 / 0)	➖

Minimum allowed line rate is 50%