Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storage deposit limit param to XVM call #1018

Merged
merged 8 commits into from
Aug 31, 2023

Conversation

shaunxw
Copy link
Member

@shaunxw shaunxw commented Aug 30, 2023

Pull Request Summary

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • updated spec version
  • updated semver

@shaunxw shaunxw added runtime This PR/Issue is related to the topic “runtime”. XVM Related to XVM labels Aug 30, 2023
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment about unused param, otherwise LGTM

pallets/xvm/src/lib.rs Outdated Show resolved Hide resolved
tests/integration/src/xvm.rs Outdated Show resolved Hide resolved
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
precompiles/assets-erc20/src 76% 0%
chain-extensions/pallet-assets/src 0% 0%
chain-extensions/types/assets/src 0% 0%
pallets/custom-signatures/src 51% 0%
pallets/dapps-staking/src/pallet 85% 0%
chain-extensions/types/dapps-staking/src 0% 0%
pallets/dapps-staking/src 81% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/pallet-xcm/src 53% 0%
chain-extensions/dapps-staking/src 0% 0%
pallets/collator-selection/src 69% 0%
precompiles/dapps-staking/src 93% 0%
precompiles/utils/macro/src 0% 0%
precompiles/batch/src 80% 0%
pallets/xvm/src 39% 0%
chain-extensions/xvm/src 0% 0%
pallets/xc-asset-config/src 53% 0%
precompiles/utils/src 68% 0%
precompiles/xcm/src 84% 0%
precompiles/substrate-ecdsa/src 78% 0%
precompiles/xvm/src 75% 0%
primitives/src 65% 0%
pallets/ethereum-checked/src 48% 0%
precompiles/sr25519/src 79% 0%
precompiles/utils/src/testing 62% 0%
primitives/src/xcm 66% 0%
pallets/contracts-migration/src 0% 0%
pallets/block-reward/src 85% 0%
Summary 57% (2560 / 4491) 0% (0 / 0)

Minimum allowed line rate is 50%

@shaunxw shaunxw merged commit 0bb294b into master Aug 31, 2023
@shaunxw shaunxw deleted the feat/xvm-storage-deposit-limit branch August 31, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”. XVM Related to XVM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants