-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dApp staking v3 & Tokenomics 2.0 - Astar Integration #1165
Conversation
/bench astar-dev pallet_dapp_staking_migration,pallet_dapp_staking_v3,pallet_inflation |
Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/7817281031. |
Benchmarks have been finished. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified numbers. LFTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
btw "static price" is still not checked out in todo in PR description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks all! @ashutoshvarma you're right about the static price. There's a discussion ongoing about this, will push an update once few opinions have been gathered. |
800ac24
Minimum allowed line rate is |
Pull Request Summary
dApp staking v3 & Tokenomics 2.0 integration into
astar
runtime.Also cleans up executed migrations from the
shiden
runtime.Resolved some TODOs by removing privileged calls.
force
in dApp staking v3 is kept, but under a newSafeguard
protection flag.Check list