Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dApp staking v3 & Tokenomics 2.0 - Astar Integration #1165

Merged
merged 14 commits into from
Feb 9, 2024

Conversation

Dinonard
Copy link
Member

@Dinonard Dinonard commented Feb 7, 2024

Pull Request Summary

dApp staking v3 & Tokenomics 2.0 integration into astar runtime.
Also cleans up executed migrations from the shiden runtime.

Resolved some TODOs by removing privileged calls.
force in dApp staking v3 is kept, but under a new Safeguard protection flag.

Check list

  • Astar integration
  • Shiden migration cleanup
  • try-runtime testing
  • chopsticks testing
  • params double-check
  • re-run benchmarks
  • static price
  • remove some privileged calls

@Dinonard Dinonard added shiden related to shiden runtime astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. labels Feb 7, 2024
@Dinonard Dinonard added the shibuya related to shibuya label Feb 7, 2024
@Dinonard Dinonard marked this pull request as ready for review February 7, 2024 15:27
@Dinonard
Copy link
Member Author

Dinonard commented Feb 7, 2024

/bench astar-dev pallet_dapp_staking_migration,pallet_dapp_staking_v3,pallet_inflation

Copy link

github-actions bot commented Feb 7, 2024

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/7817281031.
Please wait for a while.
Branch: feat/astar-dsv3-t2-integration
SHA: 2cf9a4a

Copy link

github-actions bot commented Feb 7, 2024

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/7817281031.

PierreOssun
PierreOssun previously approved these changes Feb 8, 2024
Copy link
Member

@PierreOssun PierreOssun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified numbers. LFTM

ashutoshvarma
ashutoshvarma previously approved these changes Feb 8, 2024
Copy link
Member

@ashutoshvarma ashutoshvarma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
btw "static price" is still not checked out in todo in PR description

shaunxw
shaunxw previously approved these changes Feb 8, 2024
Copy link
Member

@shaunxw shaunxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dinonard
Copy link
Member Author

Dinonard commented Feb 8, 2024

Thanks all!

@ashutoshvarma you're right about the static price. There's a discussion ongoing about this, will push an update once few opinions have been gathered.

@Dinonard Dinonard dismissed stale reviews from shaunxw, ashutoshvarma, and PierreOssun via 800ac24 February 9, 2024 06:08
@Dinonard Dinonard self-assigned this Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

Code Coverage

Package Line Rate Branch Rate Health
precompiles/dapps-staking/src 94% 0%
pallets/xc-asset-config/src 64% 0%
chain-extensions/xvm/src 0% 0%
precompiles/dapp-staking-v3/src 90% 0%
pallets/xvm/src 51% 0%
precompiles/xvm/src 74% 0%
pallets/block-rewards-hybrid/src 91% 0%
pallets/astar-xcm-benchmarks/src 89% 0%
chain-extensions/types/assets/src 0% 0%
pallets/dapps-staking/src 90% 0%
pallets/inflation/src 80% 0%
pallets/unified-accounts/src 84% 0%
precompiles/substrate-ecdsa/src 74% 0%
pallets/dapp-staking-v3/src/benchmarking 98% 0%
pallets/collator-selection/src 89% 0%
chain-extensions/unified-accounts/src 0% 0%
precompiles/sr25519/src 64% 0%
precompiles/xcm/src 72% 0%
chain-extensions/pallet-assets/src 56% 0%
pallets/dapp-staking-v3/rpc/runtime-api/src 0% 0%
pallets/dapp-staking-migration/src 48% 0%
precompiles/assets-erc20/src 81% 0%
precompiles/dapp-staking-v3/src/test 0% 0%
chain-extensions/types/unified-accounts/src 0% 0%
pallets/dynamic-evm-base-fee/src 92% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/ethereum-checked/src 75% 0%
precompiles/unified-accounts/src 100% 0%
primitives/src/xcm 66% 0%
pallets/astar-xcm-benchmarks/src/fungible 100% 0%
pallets/dapp-staking-v3/src 88% 0%
pallets/dapps-staking/src/pallet 86% 0%
pallets/astar-xcm-benchmarks/src/generic 100% 0%
pallets/dapp-staking-v3/src/test 0% 0%
pallets/static-price-provider/src 58% 0%
precompiles/dispatch-lockdrop/src 86% 0%
primitives/src 62% 0%
Summary 79% (4414 / 5588) 0% (0 / 0)

Minimum allowed line rate is 50%

@Dinonard Dinonard merged commit fc14b13 into master Feb 9, 2024
9 checks passed
@Dinonard Dinonard deleted the feat/astar-dsv3-t2-integration branch February 9, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astar Related to Astar runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya shiden related to shiden runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants