Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add UnifiedAddressMapper trait impl bechmarks #1066

Merged
merged 6 commits into from
Oct 29, 2023

Conversation

ashutoshvarma
Copy link
Member

@ashutoshvarma ashutoshvarma commented Oct 24, 2023

Closes #1062

Pull Request Summary
This PR adds new benchmarks for UnifiedAddressMapper trait implementation by pallet_unified_accounts.
Also replaces the use of hardcoded weights for trait use throughout runtime (XVM and UA CE).

TODO

  • re-run bechmarks

@ashutoshvarma ashutoshvarma added runtime This PR/Issue is related to the topic “runtime”. AU Account Unification labels Oct 24, 2023
chain-extensions/xvm/src/lib.rs Outdated Show resolved Hide resolved
chain-extensions/unified-accounts/src/lib.rs Outdated Show resolved Hide resolved
pallets/unified-accounts/src/benchmarking.rs Outdated Show resolved Hide resolved
Dinonard
Dinonard previously approved these changes Oct 27, 2023
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashutoshvarma
Copy link
Member Author

/bench shibuya-dev pallet_unified_accounts

@github-actions
Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/6664906966.
Please wait for a while.
Branch: feat/au-more-bench
SHA: 608cc5a

@github-actions
Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/6664906966.

@ashutoshvarma
Copy link
Member Author

/bench shibuya-dev pallet_unified_accounts

@github-actions
Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/6665964962.
Please wait for a while.
Branch: feat/au-more-bench
SHA: e702a4d

@github-actions
Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/6665964962.

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
precompiles/utils/src 55% 0%
chain-extensions/types/xvm/src 0% 0%
precompiles/assets-erc20/src 76% 0%
pallets/ethereum-checked/src 48% 0%
precompiles/sr25519/src 79% 0%
pallets/contracts-migration/src 0% 0%
chain-extensions/xvm/src 0% 0%
chain-extensions/types/assets/src 0% 0%
precompiles/xcm/src 75% 0%
precompiles/substrate-ecdsa/src 78% 0%
precompiles/utils/macro/src 0% 0%
precompiles/xvm/src 75% 0%
pallets/dynamic-evm-base-fee/src 81% 0%
pallets/xc-asset-config/src 53% 0%
chain-extensions/unified-accounts/src 0% 0%
chain-extensions/dapps-staking/src 0% 0%
pallets/dapps-staking/src 81% 0%
pallets/unified-accounts/src 79% 0%
chain-extensions/types/unified-accounts/src 0% 0%
chain-extensions/types/dapps-staking/src 0% 0%
primitives/src/xcm 66% 0%
precompiles/utils/src/testing 38% 0%
chain-extensions/pallet-assets/src 0% 0%
pallets/xvm/src 40% 0%
precompiles/dapps-staking/src 93% 0%
pallets/block-reward/src 85% 0%
pallets/collator-selection/src 69% 0%
pallets/dapps-staking/src/pallet 85% 0%
primitives/src 63% 0%
Summary 56% (2201 / 3925) 0% (0 / 0)

Minimum allowed line rate is 50%

@ashutoshvarma ashutoshvarma merged commit 0589b5f into master Oct 29, 2023
8 checks passed
@ashutoshvarma ashutoshvarma deleted the feat/au-more-bench branch October 29, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AU Account Unification runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add benchmarks for UnifiedAddressMapper trait implementation of pallet_unified_accounts
3 participants