Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmarks for UnifiedAddressMapper trait implementation of pallet_unified_accounts #1062

Closed
ashutoshvarma opened this issue Oct 19, 2023 · 0 comments · Fixed by #1066
Closed

Add benchmarks for UnifiedAddressMapper trait implementation of pallet_unified_accounts #1062

ashutoshvarma opened this issue Oct 19, 2023 · 0 comments · Fixed by #1066
Assignees
@ashutoshvarma
Labels
AU Account Unification project Issue is part of an ongoing project

Comments

@ashutoshvarma
Copy link
Member

Description

Currently we charge 1 DB read weight for all getters method in mapper trait impl for unified pallet. Instead of assuming the underlying functionality of trait implementation we should have benchmarks to automatically gave weights ready.

How

  • Add benchmarks for trait implementation to existing unified pallet benchmarks.
  • Replace use of hardcoded weights (1 db read) for trait use through out runtime
    • XVM
    • Chain Extensions
@ashutoshvarma ashutoshvarma added project Issue is part of an ongoing project AU Account Unification labels Oct 19, 2023
@ashutoshvarma ashutoshvarma self-assigned this Oct 19, 2023
This was referenced Oct 19, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashutoshvarma ashutoshvarma

Labels
AU Account Unification project Issue is part of an ongoing project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add UnifiedAddressMapper trait impl bechmarks AstarNetwork/Astar
1 participant
@ashutoshvarma