Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify exception throwing #39

Closed
wants to merge 2 commits into from
Closed

Simplify exception throwing #39

wants to merge 2 commits into from

Conversation

Swimburger
Copy link
Contributor

@Swimburger Swimburger commented Aug 7, 2024 •
edited
Loading

Suggestions:

  • Rename AssemblyAIClientException to AssemblyAIExceptoin
  • Rename AssemblyAIClientApiException to HttpOperationException
  • HttpOperationException, replace body with a string response content
  • Use HttpStatusCode instead of int where possible
  • Handle HTTP error codes in partial method of partial raw client, and remove error code handling from generated clients
  • AssemblyAIException should provide all constructors of base
  • Don't catch JsonException in generated clients, let it throw

@Swimburger Swimburger closed this Aug 13, 2024
@Swimburger Swimburger deleted the niels/proposed-exception-changes branch August 13, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Swimburger