cloudLibrary with alternate cards bug fixes #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Abhyastamita
commented
Aug 28, 2024
Abhyastamita
commented
- Fixed check for useAlternateCard during checkout/hold placement - it was always coming back false, which caused the prompt to enter an alternate card to show up inappropriately.
- Made form input and label alignment more consistent with other forms on library card page and alternate card popup.
- Checkouts made with a linked card will now use the cloudLibrary settings that are in the scope of the linked card's home library.
- Updated release notes
…ounts Use the cloudLibrary settings that have a scope that matches the home library of the account that is doing the checkout (either the main account or linked card).
If the user agent contains spammy content (such as "sleep(" or "SELECT") return a 404 error. The check for spammy content is case insensitive.
|
Also includes blocking spammy user agents.
|
mdnoble73
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.