Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display actual dates on x-axis #80

Merged
merged 8 commits into from
Sep 4, 2021
Merged

Display actual dates on x-axis #80

merged 8 commits into from
Sep 4, 2021

Conversation

lemewynn
Copy link
Contributor

@lemewynn lemewynn commented Sep 4, 2021

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions

  1. Does your submission pass tests?
  2. Have you lint your code locally prior to submission?

Changes to Core Features

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

These changes implement functionality mentioned in issues #64, #78 which propose to add captions to the contributions as actual dates, instead of simply listing from 1 to 31.

image_2021-09-04_16-58-06

Copy link
Collaborator

@Kshitij978 Kshitij978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the effort. This is a great addition to the quality of the project. Thanks for your awesome contribution! 🎉

@Kshitij978 Kshitij978 merged commit 1d02ab0 into Ashutosh00710:main Sep 4, 2021
@lemewynn lemewynn deleted the feature/days branch September 4, 2021 15:32
@Ashutosh00710
Copy link
Owner

@andinoriel the graph is now giving a browser compatibility issue #81
Can you propose any solution for that?

@lemewynn
Copy link
Contributor Author

lemewynn commented Sep 4, 2021

@andinoriel the graph is now giving a browser compatibility issue #81
Can you propose any solution for that?

I'll try to fix it soon

@Ashutosh00710
Copy link
Owner

Hi @andinoriel, changes proposed in this PR have been reverted temporarily.
The reasons are,

  • The cross-browser compatibility issue.
  • Cover some corner cases regarding timezones.

We will re-deploy this feature soon. This feature is a great addition, without a doubt.

@Ashutosh00710
Copy link
Owner

Hi, @andinoriel your changes are now available in production. 🚀
We don't have any solution for Safari yet. Let us know if you find anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Showing date of the contribution instead numbers NEW FEATURE REQUEST
3 participants