Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creates shared memory if it doesn't exist rather than depending on arcdps creating it #26

Merged
merged 5 commits into from
Aug 16, 2021

Conversation

coderedart
Copy link
Contributor

just copy pasted from taco's implementation.

@coderedart
Copy link
Contributor Author

closes #20

@AsherGlick
Copy link
Owner

This is awkward and I apologize but I cannot review this PR. The taco dev has been very adamant about what their software license is, and it is incompatible with the GPL.

If this PR is just a couple lines that does something like

if (size of(memory file) == 0) {
    create_memory_file(MAX_MEMORY_FILE_SIZE)
}

then I can merge it if you can find the example to it in public documentation and use theirs instead. But I cannot pull code copied from taco without the original author's approval. (see taco issue number 2)

@coderedart
Copy link
Contributor Author

It's just a syscall. Nothing about it is specific to taco. just mentioned it as a futures reference to the related code from similar project. And this is c code which taco is CPP code, that's why we need to use sizeof (struct LinkedMem) compared to taco.
More references
https://docs.microsoft.com/en-us/windows/win32/memory/creating-named-shared-memory

https://docs.microsoft.com/en-us/windows/win32/api/winbase/nf-winbase-createfilemappinga

@coderedart
Copy link
Contributor Author

But if you insist I will make a different pr tomorrow 😜

@coderedart coderedart closed this Aug 16, 2021
@coderedart
Copy link
Contributor Author

kinda my first PR. so i messed it up. help me Asher sempai :) i added 3 files instead of just the burrito_link file

@coderedart coderedart reopened this Aug 16, 2021
@AsherGlick
Copy link
Owner

I recommend using git restore to roll back the files you did not intend to submit and make a new commit that reverts them. After submitting you can use git restore again to roll back the roll back locally so you still have your changes on your machine.

@coderedart
Copy link
Contributor Author

it feels big because of formatting changes, but i tried my best to stick to the reference docs of microsoft. checked that it works.

@AsherGlick AsherGlick merged commit 29031b4 into AsherGlick:master Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants