Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various bugs #58

Merged
merged 4 commits into from
Jun 18, 2020
Merged

Fix various bugs #58

merged 4 commits into from
Jun 18, 2020

Conversation

stevelandeyasana
Copy link
Collaborator

  • Minimum iOS version was erroneously set to 9 instead of 11, causing build errors
  • README jobs link was out of date
  • In fixing Chinese text entry (Fix the bug that can't input Chinese character. #45), text entry was broken more generally and is now fixed correctly.
  • Fix buffers not being re-rendered at the new size after view size changes

FYI @max-christian

@stevelandeyasana stevelandeyasana mentioned this pull request Jun 1, 2020
Closed
russellblickhan
russellblickhan approved these changes Jun 1, 2020
View reviewed changes
Copy link

@russellblickhan russellblickhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevelandeyasana stevelandeyasana merged commit b397b65 into master Jun 18, 2020
@stevelandeyasana stevelandeyasana mentioned this pull request Jun 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellblickhan russellblickhan russellblickhan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevelandeyasana @russellblickhan