Workaround new USB using SPMI instead of I2C #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M3+ have a new USB power controller and it works over SPMI. However, the USB ports work (at least within m1n1) if we ignore this and just init the phys directly. This detects the case where we are not on an I2C based USB machine, and initializes the phys directly. Eventually we should support SPMI properly. Signed-off-By: Daniel Berlin <[email protected]>
|
Ugh. Well that's going to be fun. |
|
It's actually not too bad - turning on HPM debugging in macos shows
the actual commands that get issued are identical (IE the fourcc and
all), it's just the transport that's different.
So we just have to figure out the command execution protocol and the
rest of the code from the existing i2c driver should work.
I've been working it out in a python experiment, but it's not quite there yet.
…On Sun, Dec 3, 2023 at 3:36 AM Hector Martin ***@***.***> wrote:
Ugh. Well that's going to be fun.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
mildsunrise
added a commit
to mildsunrise/m1n1
that referenced
this pull request
Nov 9, 2024
generalizes the HPM driver over different transports, implements the SPMI transport, and takes care of waking up the device upon initialization so that commands can be sent to it. then, reverts AsahiLinux#365 and makes the necessary changes to the usb driver to use the appropriate transport as necessary. the SPMI transport is pretty much a C translation of the hpm_spmi experiment, but has more retry loops for robustness, since in my experience the device sometimes doesn't actually perform the read / write to the logical register even if it ACKs the SPMI transactions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a workaround for the lack of SPMI support in usb.c
Newer machines use SPMI and a different type C power controller.
This patch still lets us make the USB ports work by skipping power-on and just enabling the phys