Use original oref0 profile script #805
Conversation
thomasvargiu
changed the title
thomasvargiu
changed the title
thomasvargiu
changed the title
|
I've tested the for some time now. Everything seems fine. the comment about current dev/main index.js is not accurate (but not very important), as all variables are in fact included here (you can check for yourself with for instance a search in Xcode), however your solution is prettier and highly appreciated as we now can use every files from the public official ore0 repo! |
|
I was thinking to refactor the other files prepare files. It should be better to don't use the workaround to inject custom iAPS variables in the profile. They are not for oref0 and we should get them from the preferences where we need them. |
I'm open to this. There are several different ways of refactoring we can make. |
thomasvargiu
force-pushed
the
original-oref0
branch
from
179bc02 to
99d3862
Compare
|
This PR is marked as “draft”, do you have additional updates pending? |
|
It's a workaround, but it works... |
Braking changes are not ideal, and should only be introduced when absolutely necessary. What changes to the middleware were you planning? |
Removing the custom iAPS settings from the profile and move them to preferences and provide them to the middleware. But we can think about these things in the future. I'm removing the draft flag from this PR. |
thomasvargiu
changed the title
Are you referring to the dynamic ISF settings? These are already in preferences.json. But I agree it would be more structured to move these to freeaps_settings.json instead as these are not used in oref0. We could do this without breaking the middleware for most users, unless for those users trying to read these settings from preferences object in middleware (there is no good reason to as these are part of profile.json). And yes I think this PR can be merged for now and the other refactoring happening later in a separate PR. I've been testing this PR thoroughly. |
1. Hypo treatments (#801) Activate a hypo treatment override preset when selecting Hypo Treatment in the meals View. The activated override: 45 min, SMBs off, 90%, 6.5 mmol/l target. This will also skip the Bolus View. Make the necessary updates to update the override/s in Nightscout. Those who never records any hypo treatments in iAPS can disable this option in UI/UX settings. 2. Don't run TDD twice (dd5cc61) An add some more printing to console to see time of each oref0 module. 3. Expand iAPS Live Activity (#808). Display Last loop, IOB, COB and eventual glucose prediction. Add support for both open loop mode and closed loop mode. #808 4. Move max carbs (#811). Some users don't know about this new setting. It has now been moved to a more intuitive location. 5. Resolve Calender issue introdced in commit af1acf9 (#821) 6. Resolve issue #804 7. Refactor (#823) 8. Fix the rounding in small TIR chart. Every group together now always end up with 100 %. 9. Hide the COB chart when lacking carb entries. Hide the IOB chart when lacking insulin data. #824 10. Add Glucose drop to Header View Display rotating glucose drop. Current Glucose, loop minutes ago and glucose delta is now in highest contrast. The glucose delta is now an option in UI/UX settings (default is off). I recommend having “Always color glucose value” off in UI/UX settings, as this will make sure you’ll always get the glucose in highest contrast (black/white). https://discord.com/channels/1120154740857245808/1123065808130691124/1277393884053504072 11. Add pump shadows.. 12. Localize Header Clean up. 13. Fix default glucose delta setting * Display + in delta. Round manual glucose values separately. 14. Move infoPanel to be a more integral part of the header View Update animation duration. 15. Add label to the iAPS pill 16. Use original oref0 profile script (#805), by @bastiaanv https://discord.com/channels/1120154740857245808/1123065808130691124/1278662542511575041 17. Edit "Error" to "Status" (#761) 18 Bring back display of before and after the dynamic adjustment in iAPS pill. Bring back correct colour of Insulin 24h. Include CR. 19. New localizations and Crowdin translations. Thank you translators: Aleksandr Van-Zaam, Mirko Trierenberg, Typ1er, Mykola Yroslavadudko, Nicole van Elst - van den Hoek, Hung Nguyen, Salem Allebdi, aboeinas, Abdulrahman Alfantokh, 244877227, Alessandro Fogliani for new translations. We now have some Arabic translations.
* Release 5.0.0 1. Hypo treatments (#801) Activate a hypo treatment override preset when selecting Hypo Treatment in the meals View. The activated override: 45 min, SMBs off, 90%, 6.5 mmol/l target. This will also skip the Bolus View. Make the necessary updates to update the override/s in Nightscout. Those who never records any hypo treatments in iAPS can disable this option in UI/UX settings. 2. Don't run TDD twice (dd5cc61) An add some more printing to console to see time of each oref0 module. 3. Expand iAPS Live Activity (#808). Display Last loop, IOB, COB and eventual glucose prediction. Add support for both open loop mode and closed loop mode. #808 4. Move max carbs (#811). Some users don't know about this new setting. It has now been moved to a more intuitive location. 5. Resolve Calender issue introdced in commit af1acf9 (#821) 6. Resolve issue #804 7. Refactor (#823) 8. Fix the rounding in small TIR chart. Every group together now always end up with 100 %. 9. Hide the COB chart when lacking carb entries. Hide the IOB chart when lacking insulin data. #824 10. Add Glucose drop to Header View Display rotating glucose drop. Current Glucose, loop minutes ago and glucose delta is now in highest contrast. The glucose delta is now an option in UI/UX settings (default is off). I recommend having “Always color glucose value” off in UI/UX settings, as this will make sure you’ll always get the glucose in highest contrast (black/white). https://discord.com/channels/1120154740857245808/1123065808130691124/1277393884053504072 11. Add pump shadows.. 12. Localize Header Clean up. 13. Fix default glucose delta setting * Display + in delta. Round manual glucose values separately. 14. Move infoPanel to be a more integral part of the header View Update animation duration. 15. Add label to the iAPS pill 16. Use original oref0 profile script (#805), by @bastiaanv https://discord.com/channels/1120154740857245808/1123065808130691124/1278662542511575041 17. Edit "Error" to "Status" (#761) 18 Bring back display of before and after the dynamic adjustment in iAPS pill. Bring back correct colour of Insulin 24h. Include CR. 19. New localizations and Crowdin translations. Thank you translators: Aleksandr Van-Zaam, Mirko Trierenberg, Typ1er, Mykola Yroslavadudko, Nicole van Elst - van den Hoek, Hung Nguyen, Salem Allebdi, aboeinas, Abdulrahman Alfantokh, 244877227, Alessandro Fogliani for new translations. We now have some Arabic translations.
Use the original
lib/profile/index.jsfromoref0.I can't be 100% sure whether there are other changes or not, but this PR handles the errors like the actual bundled one, using the original script.
Changes:
scripts/webpack.config.jsto use original filesscripts/webpack.config.jsto allow another directory for oref0 lib using an env variablescripts/webpack.config.jswith optimizations flags for sideEffects and commentspackage.jsonto lock webpack dependencyWhen someone wants to build the oref0 lib, they can: