Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic ISF average -- possible bug #963

Closed
naromero77 opened this issue Nov 30, 2024 · 5 comments
Closed

Dynamic ISF average -- possible bug #963

naromero77 opened this issue Nov 30, 2024 · 5 comments

Comments

@naromero77
Copy link

In a previous PR, average ISF and average CR are displayed on the Dynamic ISF menu near the bottom. I never see the average CR value change on this menu. Two requests:

  1. A second look to make sure there is no bug in the average CR code
  2. For the CR, it would be helpful to have the first decimal point after the integer. As in 12.5 for example, instead of 13.
@Jon-b-m
Copy link
Member

Jon-b-m commented Nov 30, 2024

In a previous PR, average ISF and average CR are displayed on the Dynamic ISF menu near the bottom. I never see the average CR value change on this menu. Two requests:

  1. A second look to make sure there is no bug in the average CR code
  2. For the CR, it would be helpful to have the first decimal point after the integer. As in 12.5 for example, instead of 13.

The averages are based on new data (previously not saved) and therefore you need some time before these averages are displayed here. The CR is using one fraction digit currently:
image

@Jon-b-m Jon-b-m closed this as completed Nov 30, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in iAPS Development Board Nov 30, 2024
@naromero77
Copy link
Author

For the decimal point issue, we use mg/dL units and there is nothing to the right of the decimal point.

@Jon-b-m
Copy link
Member

Jon-b-m commented Nov 30, 2024

For the decimal point issue, we use mg/dL units and there is nothing to the right of the decimal point.

Where?

@Jon-b-m Jon-b-m reopened this Nov 30, 2024
@naromero77
Copy link
Author

image

Jon-b-m added a commit that referenced this issue Nov 30, 2024
@Jon-b-m
Copy link
Member

Jon-b-m commented Nov 30, 2024

Fixed here 14256c6

@Jon-b-m Jon-b-m closed this as completed Dec 1, 2024
This was referenced Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants