Dana. Tapping “Save to pump” in pump settings …

[Jon-b-m]

will make iAPS crash.

Tested with Dana RS V3 pump in both Dana and alphaDana branches.

Its in the first View (not the concentration view) you can’t tap “Save to pump” without having fatal bug.

[53645714n]

I don't have this with Dana-i

[bastiaanv]

@Jon-b-m Could you post the stacktrace here? I also cannot reproduce this issue with the Dana-i.

Including the value you use for Max Basal and max Bolus

[Jon-b-m]

Crash log:
FreeAPS-2024-12-17-172047.ips.zip

[Jon-b-m]

A quick for this could be to just disable this save button when using Dana?

[Jon-b-m]

@bastiaanv
in FreeAPS/Sources/Modules/PumpSettingsEditor/PumpSettingsEditorProvider.swift after line 34 if you add these lines the bug will be avoided (the save operation will be canceled):

guard !pump.localizedTitle.contains(NSLocalizedString("Dana", comment: "")) else {
return Just(()).setFailureType(to: Error.self).eraseToAnyPublisher()
}

We now don't have any localization for the "Dana" string yet, but the above will work even after adding it.

[bastiaanv]

@Jon-b-m does this impact the workings of APS?
I dont mind adding it, but does it impact the bolus calculation.

Originally, it should ignore the user input and just fetch whatever is stored in the pump. I would like to keep it that way, but if max bolus and max basal isnt considered by APS, then we can just add it

[Jon-b-m]

Max bolus and max basal settings are respected in iAPS.

The problem here is that since you can’t actually save these settings to Dana it would be better to either disable this save button or rename it. However having a ”fetch” button is a bit weird and unintuitive. Perhaps better to fetch upon appear instead and never display the ”save” button when using Dana, but then we need to have the fetch working. Now it unfortunately makes iAPS crash (tested with RS v.3).

[bastiaanv]

Small update, I contacted the Dutch dana importer and he will ship a DanaRS for me to debug this issue

[Jon-b-m]

@Jon-b-m does this impact the workings of APS? I dont mind adding it, but does it impact the bolus calculation.

Originally, it should ignore the user input and just fetch whatever is stored in the pump. I would like to keep it that way, but if max bolus and max basal isnt considered by APS, then we can just add it

I have a workaround, specific to Dana pumps, PR to dev now which will also work with the normal iAPS functions. Please have a look at it to see if your changes and your PR to dev now feels more complete.

[Jon-b-m]

Here: #1050