Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resync with SparseArray 1.5.22 and DelayedArray 0.31.8. #10

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Resync with SparseArray 1.5.22 and DelayedArray 0.31.8. #10

merged 1 commit into from
Jul 19, 2024

Conversation

hpages
Copy link
Contributor

@hpages hpages commented Jul 16, 2024

Various fixes aimed at putting alabaster.matrix in a state compatible with the latest developments in SparseArray and DelayedArray.

Note that SparseArray 1.5.22 and DelayedArray 0.31.8 are available on GitHub but will only propagate to the BioC 3.20 package repositories in the next couple of days.

H.

@LTLA
Copy link
Member

LTLA commented Jul 17, 2024

Looks good to me. Will merge once the required versions show up.

As an aside: now that you've seen it, do you think DelayedMask is generally useful enough for inclusion in DelayedArray? The idea is to do a substitution on the fly, without the hassle of forming an intermediate logical matrix for DelayedSubassign (and the associated redundant evaluation of the underlying matrix).

@LTLA LTLA merged commit 747c17c into ArtifactDB:master Jul 19, 2024
1 check failed
@hpages
Copy link
Contributor Author

hpages commented Jul 19, 2024

Thx! I'll take a look at your DelayedMask offer soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants