-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-data fields - Metadata fields to Kafka Connector #765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress on the PR!
A few remaining issues.
We're now validating metadata names (although the key/value are switched), but we're missing two types of validations for the user:
- Data types, which if the user sets the wrong type they get a runtime error, for example if they declare
offset_id INT GENERATED ALWAYS AS (metadata('offset_id')) STORED
and we're not validating that the metadata columns have only a metadata function in them, so this plans:
offset_id BIGINT GENERATED ALWAYS AS (concat(metadata('offset_id'), '1')) STORED
Beyond that, I'd like to see some tests, both for the deserialization logic and for planning. It might also be worth modifying the kafka tests to use metadata fields.
@mwylde can you please trigger the CI again? I am asking because my last commit ran successfully, the failed CI is on master merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is a great contribution!
enabling users to query using the following syntax -
Demo -