Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness of SSE source to server EOFs #711

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Improve robustness of SSE source to server EOFs #711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions crates/arroyo-connectors/src/sse/operator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@ use arroyo_state::tables::global_keyed_map::GlobalKeyedView;
use arroyo_types::{string_to_map, ArrowMessage, SignalMessage, UserError, Watermark};
use async_trait::async_trait;
use bincode::{Decode, Encode};
use eventsource_client::{Client, SSE};
use eventsource_client::{Client, Error, SSE};
use futures::StreamExt;
use std::collections::{HashMap, HashSet};
use std::time::{Duration, SystemTime};
use std::time::{Duration, Instant, SystemTime};
use tokio::select;
use tokio::time::MissedTickBehavior;
use tracing::{debug, info};
Expand Down Expand Up @@ -155,6 +155,8 @@ impl SSESourceFunc {
let mut flush_ticker = tokio::time::interval(Duration::from_millis(50));
flush_ticker.set_missed_tick_behavior(MissedTickBehavior::Delay);

let mut last_eof = Instant::now();

// since there's no way to partition across an event source, only read on the first task
if ctx.task_info.task_index == 0 {
loop {
Expand Down Expand Up @@ -182,6 +184,16 @@ impl SSESourceFunc {
}
}
}
Some(Err(Error::Eof)) => {
// Many SSE servers will periodically send an EOF; just reconnect
// and continue on unless we immediately get another
if last_eof.elapsed() < Duration::from_secs(5) {
ctx.report_user_error(UserError::new("Error while reading from EventSource",
"Received repeated EOF from EventSource server")).await;
panic!("Error while reading from EventSource: EOF");
}
last_eof = Instant::now();
}
Some(Err(e)) => {
ctx.control_tx.send(
ControlResp::Error {
Expand Down
Loading