Skip to content

Commit

Permalink
Re-enable c sharp arrow flight integration test (apache#6611)
Browse files Browse the repository at this point in the history
  • Loading branch information
alamb authored Oct 24, 2024
1 parent 1295b00 commit 1103939
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,7 @@ jobs:
ARROW_RUST_EXE_PATH: /build/rust/debug
BUILD_DOCS_CPP: OFF
ARROW_INTEGRATION_CPP: ON
# Disable C# integration tests due to https://github.com/apache/arrow-rs/issues/6577
ARROW_INTEGRATION_CSHARP: OFF
ARROW_INTEGRATION_CSHARP: ON
ARROW_INTEGRATION_GO: ON
ARROW_INTEGRATION_JAVA: ON
ARROW_INTEGRATION_JS: ON
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,13 @@ type Result<T = (), E = Error> = std::result::Result<T, E>;
/// Run a scenario that tests integration testing.
pub async fn scenario_setup(port: u16) -> Result {
let addr = super::listen_on(port).await?;
let resolved_port = addr.port();

let service = FlightServiceImpl {
server_location: format!("grpc+tcp://{addr}"),
// See https://github.com/apache/arrow-rs/issues/6577
// C# had trouble resolving addressed like 0.0.0.0:port
// server_location: format!("grpc+tcp://{addr}"),
server_location: format!("grpc+tcp://localhost:{resolved_port}"),
..Default::default()
};
let svc = FlightServiceServer::new(service);
Expand Down

0 comments on commit 1103939

Please sign in to comment.