Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sherlock #159

Merged
merged 2 commits into from
Aug 23, 2023
Merged

fix: sherlock #159

merged 2 commits into from
Aug 23, 2023

Conversation

Gevarist
Copy link
Contributor

No description provided.

@Gevarist
Copy link
Contributor Author

Gevarist commented Aug 10, 2023 •
edited
Loading

Here you can find solution for #198 and #8 issue of sherlock audits.

For #198: we created a new internal function _collectFeesOnPools that will be called before setting manager fees.
For # 8 : we change getAmountsDelta to the correct inequality.

This was referenced Aug 16, 2023
Open
Open
Closed
Closed
Closed
@Gevarist Gevarist merged commit 76d67ab into tests/new-test Aug 23, 2023
@kassandraoftroy kassandraoftroy deleted the fix/sherlock branch September 1, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Gevarist