Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

page-404: #199

Merged
merged 35 commits into from
Apr 28, 2024
Merged

page-404: #199

merged 35 commits into from
Apr 28, 2024

Conversation

krovostcora
Copy link
Contributor

Things added:

  • page404
  • customized cursor
  • cat animations

error page :

2024-04-25.14.08.07.mov

animations and cursor :

2024-04-25.14.06.28.mov

@krovostcora
rewrited prewious branch page-404:
ccb2b62 
added here:
 - page404
 - customized cursor
 - cat animations
@krovostcora
Merge branch 'master' into page404
d72cb42 
# Conflicts:
#	webapp/package-lock.json
#	webapp/package.json
@krovostcora krovostcora changed the title rewrited prewious branch page-404: page-404: Apr 25, 2024
@didierrc
Copy link
Contributor

Good job on those additions!! It seems that e2e tests are not passing :( did you merge your branch with the tests currently on master? I think they are up to date and I don't think that your changes affect on them, so check that out please!

@krovostcora
Copy link
Contributor Author

Good job on those additions!! It seems that e2e tests are not passing :( did you merge your branch with the tests currently on master? I think they are up to date and I don't think that your changes affect on them, so check that out please!

thanks!)
Yes, I merged it on master, and they are up-to-date for now, but e2e tests are still not passing. I am trying to figure out what else could be causing the problems ! :)

@krovostcora
trying to fix e2e test error
77a1be1 
- animations size on the screen caused the errors
@krovostcora
Copy link
Contributor Author

e2e tests were failing because of the size of the animations. I've made them smaller.

But now I'm not sure if they are not too small to add...?

Знімок екрана 2024-04-27 о 05 52 04 Знімок екрана 2024-04-27 о 05 52 20

@didierrc didierrc requested a review from carlosmndzg April 27, 2024 16:21
@didierrc
Copy link
Contributor

Thank you for fixing the errors so e2e test passes, but careful because you are uploading the .idea folder and you shouldn't!

@krovostcora
Copy link
Contributor Author

Thank you for fixing the errors so e2e test passes, but careful because you are uploading the .idea folder and you shouldn't!

thank you for noticing! done :)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@carlosmndzg carlosmndzg merged commit 715c9a4 into master Apr 28, 2024
4 checks passed
@didierrc didierrc mentioned this pull request Apr 30, 2024
Closed
@krovostcora krovostcora mentioned this pull request Apr 30, 2024
Closed
@carlosmndzg carlosmndzg mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosmndzg carlosmndzg carlosmndzg approved these changes

@codescene-delta-analysis codescene-delta-analysis[bot] codescene-delta-analysis[bot] approved these changes

Assignees

@krovostcora krovostcora

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krovostcora @didierrc @carlosmndzg