Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page 404 #192

Closed
wants to merge 10 commits into from
Closed

Page 404 #192

wants to merge 10 commits into from

Conversation

krovostcora
Copy link
Contributor

I've added page404 + light/dark cursors
page404

didierrc
didierrc requested changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@didierrc didierrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems nice but one test is failing because it does not encounter the "Lottie" package. Did you add it to the package.json? perhaps that solves the issue of the test

@krovostcora krovostcora deleted the page-404 branch April 25, 2024 11:30
@krovostcora krovostcora mentioned this pull request Apr 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didierrc didierrc didierrc requested changes

@codescene-delta-analysis codescene-delta-analysis[bot] codescene-delta-analysis[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krovostcora @didierrc