Header changes #177
Merged
Header changes #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now language selector has an animation for opening and closing - Now language selector will be closed when you click in any other part of the app even if you didn't explicitly close it or choose a different language - Now the volume slider floaating window have a new animation for appearing or dissapearing
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Comment on lines
-100
to
-108
| {user && ( | ||
| <Link to="settings" className="nav-link"> | ||
| <div className="nav-link-icon"> | ||
| <SettingsIcon /> | ||
| </div> | ||
| {t("settings.title")} | ||
| </Link> | ||
| )} | ||
|
|
There was a problem hiding this comment.
✅ Getting better: Complex Method
Nav decreases in cyclomatic complexity from 15 to 14, threshold = 9
This was
linked to
issues
Apr 28, 2024
|
didierrc
approved these changes
Apr 28, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the Language Selector and Volume Slider is integrated in the Header and removed from the options page.
Please check it and if you find any error or bug tell it to me, you have a bit of a preview in #143 that is the issue for this change