Completed the functions. #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArpitShukIa
reviewed
Feb 21, 2022
Comment on lines
+36
to
+37
| for (i in 1 until lines.size) { | ||
| var line = lines[i] |
There was a problem hiding this comment.
You could have also used lines.forEach { line -> instead.
ArpitShukIa
reviewed
Feb 21, 2022
Comment on lines
+38
to
+39
| line = line.replace("\\s+".toRegex(), " ") | ||
| var eachResponse = line.split(" ") |
There was a problem hiding this comment.
Kotlin has an overload for split function which directly accepts a Regex.
ArpitShukIa
reviewed
Feb 21, 2022
Comment on lines
+51
to
+53
| var allResponseBranchWise = mutableListOf<List<Response>>() | ||
| groupByBranch.forEach { (k, v) -> | ||
| allResponseBranchWise.add(v) |
There was a problem hiding this comment.
Map has a values property which essentially gives a collection of all values. using that you could have avoided this loop.
ArpitShukIa
reviewed
Feb 21, 2022
Comment on lines
+55
to
+57
| var threedList = allResponseBranchWise.chunked(3) | ||
| var req = mutableListOf<List<Response>>() | ||
| threedList.forEach { req.add(it.flatten()) } |
There was a problem hiding this comment.
Here also, you could have used the map function and avoided this new MutableList.
ArpitShukIa
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.