include complete redirect rule feature #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 16, 2022 10:34
1. update adblock-rust => 0.4.3 2. add `include_redirect_urls` parameter for `FilterSet.add_filter_list` and `FilterSet.add_filters` 3. add `Engine.add_resource` method. 4. add `adblock.AddResourceError` Exception 5. add `redirect_type` for `BlockerResult` 6. add some tests for these functions.
|
Some implementations refer to the https://github.com/brave/adblock-rust-ffi. |
added 2 commits
February 17, 2022 10:31
ArniDagur
requested changes
Feb 17, 2022
…rResult implementations
|
@ArniDagur still have something not ready to merge? |
|
Thank you for your contribution. This has been merged as #60. |
can you release a new version on pypi.org? thank you. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jun 16, 2022
https://build.opensuse.org/request/show/982852 by user mia + dimstar_suse - Update to 0.5.2 * Include complete redirect rule feature (gh#ArniDagur/python-adblock#59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, thanks for this project first, it helps me a lot.
in this PR, I complete some feature about scriptlet injection and redirect rules.
include_redirect_urlsparameter forFilterSet.add_filter_listandFilterSet.add_filtersEngine.add_resourcemethod.adblock.AddResourceErrorExceptionredirect_typeforBlockerResult