Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marker text for Copy Mission SQF Module #436

Merged
merged 9 commits into from
Jan 8, 2019
Merged

Marker text for Copy Mission SQF Module #436

merged 9 commits into from
Jan 8, 2019

Conversation

neilzar
Copy link
Collaborator

@neilzar neilzar commented Jan 3, 2019 •
edited
Loading

When merged this pull request will:

  • Include marker text in the output of the Copy Mission SQF module.
  • Remove objNull from the curatorEditableObjects to reduce output size.

Probably the most wanted change to Achilles in our community.

@Kexanone Kexanone self-requested a review January 4, 2019 01:58
@Kexanone Kexanone self-assigned this Jan 4, 2019
@Kexanone Kexanone requested review from CreepPork and removed request for CreepPork January 4, 2019 01:58
@Kexanone Kexanone added feature PR that adds a new feature to Achilles. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. testing/not tested Indicates that the PR's latest commit has not been tested and needs testing before merging. labels Jan 4, 2019
@Kexanone Kexanone added this to the 1.3.0 milestone Jan 4, 2019
Kexanone
Kexanone reviewed Jan 4, 2019
View reviewed changes
Copy link
Member

@Kexanone Kexanone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but needs to be tested.

@neilzar
Copy link
Collaborator Author

neilzar commented Jan 4, 2019

Testing it locally I found no issues when copying markers with and without text. Haven't tested it in a dedicated environment.

CreepPork
CreepPork previously approved these changes Jan 4, 2019
View reviewed changes
@neilzar
Copy link
Collaborator Author

neilzar commented Jan 4, 2019

I now remove all objNull from the curatorEditableObjects list, they were filling up the output.

@neilzar
Copy link
Collaborator Author

neilzar commented Jan 4, 2019

I tested this in a dedicated environment; works like a charm.

@CreepPork CreepPork added testing/tested Indicates that the PR's latest commit has been tested and is working properly. and removed testing/not tested Indicates that the PR's latest commit has not been tested and needs testing before merging. labels Jan 4, 2019
@Kexanone Kexanone merged commit 34fab5b into ArmaAchilles:master Jan 8, 2019
@neilzar neilzar deleted the mission-sqf-marker-text branch January 9, 2019 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kexanone Kexanone Kexanone left review comments

@CreepPork CreepPork CreepPork approved these changes

Assignees

@Kexanone Kexanone

Labels
feature PR that adds a new feature to Achilles. priority/low Issue or PR that has no significant impact and does not negatively impact the current user base. testing/tested Indicates that the PR's latest commit has been tested and is working properly.
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@neilzar @CreepPork @Kexanone