Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Achilles_fnc_getWeaponsMuzzlesMagazines case insensitive regarding magazines #419

Merged
merged 4 commits into from
Dec 8, 2018
Merged

Make Achilles_fnc_getWeaponsMuzzlesMagazines case insensitive regarding magazines #419

merged 4 commits into from
Dec 8, 2018

Conversation

Kexanone
Copy link
Member

@Kexanone Kexanone commented Dec 7, 2018

When merged this pull request will:

  • Get Achilles_fnc_getWeaponsMuzzlesMagazines working even if the capitalization of config magazines and magazines respective magazinesTurret don't match.
  • Thus resolve the issue that the suppressive fire module could not be applied to the vanilla static GMG turret.

@Kexanone Kexanone added fix PR that is a fixes a bug. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time. testing/tested Indicates that the PR's latest commit has been tested and is working properly. labels Dec 7, 2018
@Kexanone Kexanone added this to the 1.2.1 milestone Dec 7, 2018
@Kexanone Kexanone self-assigned this Dec 7, 2018
@Kexanone Kexanone requested a review from CreepPork December 7, 2018 22:18
@CreepPork CreepPork merged commit 5ef2437 into master Dec 8, 2018
@CreepPork CreepPork deleted the caseInsenstiveWeaponMuzzleMagazineFnc branch December 8, 2018 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CreepPork CreepPork CreepPork approved these changes

Assignees

@Kexanone Kexanone

Labels
fix PR that is a fixes a bug. priority/medium Issue or PR that impacts some portions of the user base and should be resolved with due time. testing/tested Indicates that the PR's latest commit has been tested and is working properly.
Projects
None yet
Milestone
1.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Kexanone @CreepPork